Fix the typo in the "Display visitor groups" Settings switch label.

[techanvil]

Feature Description

As mentioned on #8424 (comment), there was initially a typo in the copy for the "Display visitor groups" Settings switch label (it read "Display visitors groups").

The copy should be updated, in line with the updated Figma design, to read "Display visitor groups in dashboard".

While updating this copy we should also address a minor code organisation issue introduced by the same issue.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• The copy for the "Display visitor groups" Settings switch label should read: Display visitor groups in dashboard
• Non-functional, but the SettingsCardVisitorGroups component should be moved to either assets/js/modules/analytics-4/components/settings/AudienceSegmentation/, in line with the initial code organization section in the design doc, or, to assets/js/modules/analytics-4/components/audience-segmentation/settings/ if 8495 has been implemented before this issue.

Implementation Brief

• In assets/js/components/settings/SettingsCardVisitorGroups.js:
  • Update the label of the only Switch element to a translatable Display visitor groups in dashboard string.
  • Also update the string in the test file SettingsCardVisitorGroups.test.js.
• Move the SettingsCardVisitorGroups.js and its associated story and test files to assets/js/modules/analytics-4/components/settings/AudienceSegmentation or assets/js/modules/analytics-4/components/audience-segmentation/settings/ if 8495 has been already merged.

Test Coverage

• Tests should be updated as described above.

QA Brief

• Go to Site Kit > Settings > Admin Settings. There should be Visitor groups panel with a toggle setting.
• Label for toggle should read Display visitor groups in dashboard
• Open the browser console and in network tab, notice that when we change the state of the toggle, it should send a request to google-site-kit/v1/modules/analytics-4/data/audience-settings. Request should be successful with 200 status code.

Changelog entry

• Fix typo in the "Visitor groups" admin setting.

[techanvil]

IB ✅

[kelvinballoo]

QA Update ✅

Tested this on develop on WP 6.5.2 PHP 8.0 and it's looking good:

• Copy has been updated: There is no plural for the word 'visitor'
  
• Toggling the setting on and off will trigger the required request with 200 status to:
  google-site-kit/v1/modules/analytics-4/data/audience-settings.
  

Moving ticket to Approved.