Update Audience Segmentation component path structure.

[techanvil]

Feature Description

The initial spec for the Audience Segmentation component code organisation is a little inconsistent and has caused us to provide a workaround to satisfy for our assets/js/modules/index.test.js test suite.

We should improve the organisation and move all of the Audience Segmentation components under a new assets/js/modules/analytics-4/components/audience-segmentation/ directory.

This is a non-critical issue that can be implemented post-launch if needs be, hence the P2 priority.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• The components under assets/js/modules/analytics-4/components/dashboard/AudienceSegmentation/, assets/js/modules/analytics-4/components/settings/AudienceSegmentation/ etc should be moved to:
  • assets/js/modules/analytics-4/components/audience-segmentation/dashboard/
  • assets/js/modules/analytics-4/components/audience-segmentation/settings/
  • ... and so forth.

Implementation Brief

Note, it looks like the workaround mentioned in the Feature Description will have been removed and the related test suite updated instead. The workaround or test suite update should be revised/removed as appropriate.

• Move all files from assets/js/modules/analytics-4/components/dashboard/AudienceSegmentation to assets/js/modules/analytics-4/components/audience-segmentation/dashboard.
• Mode all files from assets/js/modules/analytics-4/components/settings/AudienceSegmentation/ to assets/js/modules/analytics-4/components/audience-segmentation/settings.
  • Currently, this directory does not exist, but it may exist depending on Fix the typo in the "Display visitor groups" Settings switch label. #8496.
• Update imports in the moved files and the consuming files.
• Update story labels when appropriator.
• In assets/js/modules/index.test.js:
  • Remove the AudienceSegmentation workaround from components/%s has an index module with all components exported test.

Test Coverage

• Update any failing test and snapshots.

QA Brief

QA Eng

• The QA process can be skipped since no user-facing changes are implemented as part of this ticket. Hence, QA can be carried out during the code review.
• Verify that the Audience Segmentation dashboard components are moved to the new assets/js/modules/analytics-4/components/audience-segmentation/dashboard directory.
• Verify that the Audience Segmentation settings components are moved to the new assets/js/modules/analytics-4/components/audience-segmentation/settings directory.
• Verify that the stories are organized into Modules/Analytics4/Components/AudienceSegmentation/Dashboard and Modules/Analytics4/Components/AudienceSegmentation/Settings respectively.
• Verify all the stories work as expected.

Changelog entry

• N/A

[techanvil]

IB ✅

The estimate looks a little on the high side, but I'll leave it, we have had a tendency to go over the estimate for Audience Segmentation issues and it's possible there could be unexpected complications when updating the tests.

[techanvil]

As per the QAB, this is simply a code reorg with no user facing changes, which I've effectively QA'd during CR.

QA ✅

• Verify that the Audience Segmentation dashboard components are moved to the new assets/js/modules/analytics-4/components/audience-segmentation/dashboard directory. ✅
• Verify that the Audience Segmentation settings components are moved to the new assets/js/modules/analytics-4/components/audience-segmentation/settings directory. ✅
• Verify that the stories are organized into Modules/Analytics4/Components/AudienceSegmentation/Dashboard and Modules/Analytics4/Components/AudienceSegmentation/Settings respectively. ✅
• Verify all the stories work as expected. ✅