SwG PoC: Bulk Edit #4150
SwG PoC: Bulk Edit #4150
Conversation
assets/js/modules/subscribe-with-google/components/posts/AccessSelector.js
Outdated
Show resolved
Hide resolved
assets/js/modules/subscribe-with-google/components/posts/AccessSelector.js
Outdated
Show resolved
Hide resolved
| add_filter( | ||
| 'manage_post_posts_columns', | ||
| function( $columns ) { | ||
| return array_merge( $columns, array( 'sitekit__reader_revenue__access' => __( 'Access', 'google-site-kit' ) ) ); | ||
| } | ||
| ); | ||
|
|
||
| add_action( | ||
| 'manage_post_posts_custom_column', | ||
| function( $column_key, $post_id ) { | ||
| if ( 'sitekit__reader_revenue__access' === $column_key ) { | ||
| $access = get_post_meta( $post_id, 'sitekit__reader_revenue__access', true ); | ||
| if ( $access && 'openaccess' !== $access ) { | ||
| echo esc_html( $access ); | ||
| } else { | ||
| esc_html_e( '— Free —', 'google-site-kit' ); | ||
| } | ||
| } | ||
| }, | ||
| 10, | ||
| 2 | ||
| ); |
There was a problem hiding this comment.
No technical concern with this code, but from a UX perspective I wonder if that is the most appropriate way to show the access information for a post in the table. A whole column takes a lot of space, and while users can hide columns in the UI, I think there may be more subtle ways that would also show this information closer to e.g. the post title. Especially since not every post is expected to have a special state (thinking about sites that would monetize let's say 5 out of 100 posts), I'm not sure this is worth a column.
For Idea Hub for example, we display something additional right in the post title column. Maybe that could be a path.
You probably don't need to change that here unless you feel strongly about that, but I think this may get flagged from a UX perspective eventually.
There was a problem hiding this comment.
I don't feel strongly either way, just wanna build something you and the Site Kit team are happy with
Summary
Addresses issue #
Relevant technical choices
Checklist