-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance/#7598 - Add GA4 availableCustomDimensions
module setting and relevant datastore infrastructure
#7666
Enhance/#7598 - Add GA4 availableCustomDimensions
module setting and relevant datastore infrastructure
#7666
Conversation
Build files for 0be09ec have been deleted. |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @hussain-t. This is a very solid start. Found some minor issues that we need to fix before merging this PR. Please, take a look at my comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, @hussain-t. Approved!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, there are PHP issues in e2e tests that we need to fix to prevent them failing. @hussain-t, could you please take a look at it?
@eugene-manuilov, those aren't related to the changes involved in this PR. I've seen them failing in other PR as well. Let me re-check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks, @hussain-t. Looks like that is not relevant to these changes. Ok, approving this PR.
Summary
Addresses issue:
availableCustomDimensions
module setting and relevant datastore infrastructure #7598Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist