Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance/#7598 - Add GA4 availableCustomDimensions module setting and relevant datastore infrastructure #7666

Conversation

hussain-t
Copy link
Collaborator

@hussain-t hussain-t commented Oct 5, 2023

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Build files for 0be09ec have been deleted.

@github-actions

This comment was marked as resolved.

Copy link
Collaborator

@eugene-manuilov eugene-manuilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hussain-t. This is a very solid start. Found some minor issues that we need to fix before merging this PR. Please, take a look at my comments.

Copy link
Collaborator

@eugene-manuilov eugene-manuilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, @hussain-t. Approved!

Copy link
Collaborator

@eugene-manuilov eugene-manuilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, there are PHP issues in e2e tests that we need to fix to prevent them failing. @hussain-t, could you please take a look at it?

@hussain-t
Copy link
Collaborator Author

hussain-t commented Oct 6, 2023

Actually, there are PHP issues in e2e tests that we need to fix to prevent them failing. @hussain-t, could you please take a look at it?

@eugene-manuilov, those aren't related to the changes involved in this PR. I've seen them failing in other PR as well. Let me re-check.

Copy link
Collaborator

@eugene-manuilov eugene-manuilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks, @hussain-t. Looks like that is not relevant to these changes. Ok, approving this PR.

@eugene-manuilov eugene-manuilov merged commit e0daca1 into develop Oct 6, 2023
21 of 24 checks passed
@eugene-manuilov eugene-manuilov deleted the enhance/#7598-available-custom-dimensions-module-setting branch October 6, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants