-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audience Introductory Popup Overlay Notification (+Additional Refactoring) #8492
Audience Introductory Popup Overlay Notification (+Additional Refactoring) #8492
Conversation
Build files for 325fb6f have been deleted. |
Size Change: +13.5 kB (+1%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving some questions and thoughts for the code reviewer here!
...onents/OverlayNotification/AnalyticsAndAdSenseAccountsDetectedAsLinkedOverlayNotification.js
Outdated
Show resolved
Hide resolved
assets/js/components/OverlayNotification/OverlayNotificationsRenderer.js
Outdated
Show resolved
Hide resolved
assets/sass/components/overlay-notification/_googlesitekit-overlay-notification.scss
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work on this, thank you @kuasha420 !
I have left some feedback over the implementation, let me know what you think, thanks!
assets/js/components/OverlayNotification/OverlayNotification.js
Outdated
Show resolved
Hide resolved
assets/js/components/OverlayNotification/OverlayNotification.js
Outdated
Show resolved
Hide resolved
...onents/OverlayNotification/AnalyticsAndAdSenseAccountsDetectedAsLinkedOverlayNotification.js
Outdated
Show resolved
Hide resolved
assets/js/components/OverlayNotification/AudienceSegmentationIntroductoryOverlayNotification.js
Outdated
Show resolved
Hide resolved
assets/sass/components/overlay-notification/_googlesitekit-overlay-notification.scss
Outdated
Show resolved
Hide resolved
assets/sass/components/overlay-notification/_googlesitekit-overlay-notification.scss
Show resolved
Hide resolved
...e-kit_Components_AudienceSegmentationIntroductoryOverlayNotification_0_document_1_medium.png
Outdated
Show resolved
Hide resolved
assets/js/components/OverlayNotification/OverlayNotification.js
Outdated
Show resolved
Hide resolved
assets/js/components/OverlayNotification/OverlayNotification.js
Outdated
Show resolved
Hide resolved
...ashboard/AudienceSegmentation/AudienceSegmentationIntroductoryOverlayNotification.stories.js
Outdated
Show resolved
Hide resolved
assets/js/components/OverlayNotification/AudienceSegmentationIntroductoryOverlayNotification.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks excellent now, thank you @kuasha420 !
I have left two very minor comments above for your consideration, please let me know what you think, thanks!
Thank you @nfmohit for the amazing review here and being patient with this PR. I've addressed your last review. Please have a look. Cheers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks excellent now, thanks so much for the hard work here, @kuasha420! LGTM ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to point out for future reference, this is an expected change based on the Figma designs here.
Summary
Addresses issue:
Relevant technical choices
Besides adding the overlay notification for Audience, this PR also refactors the Overlay Notification infra to support a more unified mobile, tablet and desktop design. This has been confirmed by @sigal-teller from UX side and the changes in the design for the Audience Popup has been also backported to AdSense+GA4 overlay notifications. Thank you Sigal for providing additional mobile design for the GA4+AS notifications and unifying the design across the board! ❤️
Barring any CR feedback and potentially a better name other than OverlayNotification (due to the difference in design between screen sizes, this is not always an overlay!). This should be good to go.
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist