fix: When installing skia on Windows, using emsdk.py, the option --permanent is required for setting environment variables. #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmanent is required for setting environment variables.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
This PR (HEAD: a3d795d) has been imported to Gerrit for code review. Please visit review.skia.org/746436 to see it. Please CC yourself to the Gerrit change. Note:
|
|
This PR is being closed because review.skia.org/746436 has been merged. |
psyirius
pushed a commit
to psyirius/skia
that referenced
this pull request
Aug 30, 2023
…rmanent is required for setting environment variables. When installing skia on Windows, using emsdk.py, the option --permanent is required for setting environment variables. - If the `--permanent` option is passed, then the environment variables are set permanently for the current user. This is an imported pull request from google#145 GitOrigin-RevId: 99e25ae Change-Id: Ic0d28075bdb9f1f2d14023d7296411fd8374f136 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/746436 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing skia on Windows, using emsdk.py, the option --permanent is required for setting environment variables.
--permanentoption is passed, then the environment variables are set permanently for the current user.