Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syntax: drop legacy (0644) octal literals #205

Merged
merged 1 commit into from
May 28, 2019
Merged

syntax: drop legacy (0644) octal literals #205

merged 1 commit into from
May 28, 2019
+5 −13

Conversation

alandonovan
Copy link
Contributor

Use 0o644 instead.

See also bazelbuild/bazel#8059

@adonovan
syntax: drop legacy (0644) octal literals
da2b941 
Use 0o644 instead.

Change-Id: If63a84ea7817035a3874cc3947f259856828fefd
@alandonovan
Copy link
Contributor Author

@laurentlb

laurentlb
laurentlb approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@laurentlb laurentlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alandonovan alandonovan merged commit a475931 into master May 28, 2019
@alandonovan alandonovan deleted the remove-legacy-octal branch May 28, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayconrod jayconrod jayconrod approved these changes

@laurentlb laurentlb laurentlb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alandonovan @jayconrod @laurentlb @adonovan