starlark,resolve,internal/compile: replace log.Fatal with panic #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alandonovan
reviewed
Aug 19, 2019
|
Done. |
alandonovan
approved these changes
Aug 19, 2019
|
Sorry, do you mind changing the CL description to say "so that we get a stack"? I don't agree that a library shouldn't kill its process. I think it's the correct way to handle unrecoverable errors. |
Replace calls to log.Fatal/log.Fatalf with log.Panicf calls so that we get a stacktrace.
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've replaced some calls to
log.Fatalandlog.Fatalfwith panics. I believe those are all unreachable internal errors (in practice) so this is a somewhat inconsequential nitpick; however if this code were ever to execute, I believe a recoverable panic, carrying stacktrace information is preferrable to getting the calling process instantly killed.