Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update deps #387

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: update deps #387

wants to merge 1 commit into from

Conversation

ecasilla
Copy link

No description provided.

Copy link
Collaborator

@adonovan adonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a note in the PR description explaining why this change is necessary? I would expect that, as far as your application is concerned, all of these dependencies are just minimum version constraints, and you can choose higher ones if you need to. Is there some bug (or security vulnerability) in the go.starlark.net module itself that is fixed by this upgrade?

@@ -1,13 +1,13 @@
module go.starlark.net

go 1.13
go 1.17
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff doesn't seem necessary: this module doesn't require a recent version of Go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants