Support setting and iterating over map keys #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm running go1.20.8, and my gofmt insists on this formatting. Not sure why it's different from what's in master. Signed-off-by: Nic Cope <nicc@rk0n.org>
Signed-off-by: Nic Cope <nicc@rk0n.org>
For now with random iteration. I'll work on stable iteration in a future commit. Signed-off-by: Nic Cope <nicc@rk0n.org>
Signed-off-by: Nic Cope <nicc@rk0n.org>
This switches to using a dedicated test.proto file, since the descriptor.proto file previously being used doesn't have any map fields. Signed-off-by: Nic Cope <nicc@rk0n.org>
It doesn't seem to exist - I don't think it was ever committed to this public repo. Signed-off-by: Nic Cope <nicc@rk0n.org>
Signed-off-by: Nic Cope <nicc@rk0n.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #381
This PR introduces a new
MapFieldtype, which can be used to set and access map field values by key.Without this PR I get a panic in
toStarlark1wherex.Message()is called on a map field value. (Perhaps because my proto has somemap<string, Message>fields):I've also updated the nascent
proto.starunit tests to use their own proto file, to test repeated and map fields.Separately from the main change, I've included a commit that adds a list-like
appendmethod toRepeatedField. I can break that out into a separate PR if you'd prefer.