Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting and iterating over map keys #511

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Support setting and iterating over map keys #511

wants to merge 7 commits into from

Commits on Oct 1, 2023

  1. gofmt proto.go 

    I'm running go1.20.8, and my gofmt insists on this formatting. Not sure
why it's different from what's in master.

Signed-off-by: Nic Cope <nicc@rk0n.org>
    @negz
    negz committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    ca7b665 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Support appending to protobuf repeated fields 

    Signed-off-by: Nic Cope <nicc@rk0n.org>
    @negz
    negz committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    95e925a View commit details
    Browse the repository at this point in the history

  2. Support protobuf maps 

    For now with random iteration. I'll work on stable iteration in a future
commit.

Signed-off-by: Nic Cope <nicc@rk0n.org>
    @negz
    negz committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    82ea9f9 View commit details
    Browse the repository at this point in the history

  3. Sort protobuf maps by key 

    Signed-off-by: Nic Cope <nicc@rk0n.org>
    @negz
    negz committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    d1f4465 View commit details
    Browse the repository at this point in the history

  4. Add tests for protobuf map fields 

    This switches to using a dedicated test.proto file, since the
descriptor.proto file previously being used doesn't have any map fields.

Signed-off-by: Nic Cope <nicc@rk0n.org>
    @negz
    negz committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    171160d View commit details
    Browse the repository at this point in the history

  5. Remove mention of proto_test.go 

    It doesn't seem to exist - I don't think it was ever committed to this
public repo.

Signed-off-by: Nic Cope <nicc@rk0n.org>
    @negz
    negz committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    2531872 View commit details
    Browse the repository at this point in the history

  6. Add brief documentation for the MapField type 

    Signed-off-by: Nic Cope <nicc@rk0n.org>
    @negz
    negz committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    eb7d2e4 View commit details
    Browse the repository at this point in the history