stenoread timeout

[hosom]

I am trying to find why the stenoread timeout was set to a nonconfigurable 890 seconds.

I've traced the change back to 2ddbee0. Was there a particular reason that a timeout was set, other than as a means to let the user know that the number of packets returned was a LOT?

[gconnell]

The server itself throws out replys after 900 seconds, so I thought I'd let the client die first.

https://github.com/google/stenographer/blob/master/env/env.go#L99 sets the server timeout to 15 minutes.

Totally willing to make either/both of those timeouts configurable, but in general I needed some way to stop a connection that was going totally haywire.

In general, Steno is optimized to store lots of packets and return a small, targeted set. Note that if you're returning any appreciable percentage of the packets you store, Steno is probably thrashing your disk VERY hard.

[hosom]

The returned pcaps are in the Gigabyte sizes on a 340TB packet store, so it's probably below 1% of data returned... I don't know the internals of how steno reads back packets well enough to say what the impact of that is though.

…

On Tue, Jul 25, 2017 at 11:24 AM Graeme Connell ***@***.***> wrote: The server itself throws out replys after 900 seconds, so I thought I'd let the client die first. https://github.com/google/stenographer/blob/master/env/env.go#L99 sets the server timeout to 15 minutes. Totally willing to make either/both of those timeouts configurable, but in general I needed some way to stop a connection that was going totally haywire. In general, Steno is optimized to store lots of packets and return a small, targeted set. Note that if you're returning any appreciable percentage of the packets you store, Steno is probably thrashing your disk VERY hard. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#162 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEyO7O4paXRo04jqfIasW0JAfLhOVu5bks5sRgYqgaJpZM4OifhZ> .