Fixed --root option under Windows #346
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Consder contributing to the fork at https://github.com/cpplint/cpplint |
dwvisser
added a commit
to dwvisser/cpplint
that referenced
this pull request
Aug 23, 2020
Credit goes to google#346 for determining this fix. My team has had cpplint failures on Windows because of cpplint not handling paths correctly.
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --root option and CPPLINT.cfg "root=" setting does not work under Windows,
at least not for relative paths,
due to the way the absolute path for the root is obtained.