build: add a CMake based build for swift-benchmarks #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a CMake based build system for swift-benchmark, enabling support on Windows. This support includes optionally building the example programs and covers the test suite. The exports file also is generated for ease in using in other projects. The test suite is best run in an automated fashion using `cmake --build /BinaryCache/current/swift-benchmark --target test` (aka `ninja test`).
|
Hi @compnerd, the addition of cmake sounds like a fantastic addition! I was wondering how hard would it be to include cmake in the github actions CI to make sure we don't break the build in the future? |
|
That shouldn’t be too difficult. It does involve some work to install ninja on each run as the request to install ninja on the image’s was denied. |
|
LGTM! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a CMake based build system for swift-benchmark, enabling
support on Windows. This support includes optionally building the
example programs and covers the test suite. The exports file also
is generated for ease in using in other projects.
The test suite is best run in an automated fashion using
cmake --build /BinaryCache/current/swift-benchmark --target test(akaninja test).