syz-manager: add comment explaining why we don't set corrupted for re…

…pros
google · Jan 10, 2018 · 02a19b6 · 02a19b6
1 parent 1f60c82
commit 02a19b6
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/pkg/report/testdata/linux/report/152 b/pkg/report/testdata/linux/report/152
@@ -0,0 +1,24 @@
+TITLE: possible deadlock
+CORRUPTED: Y
+
+[....] Starting enhanced syslogd: rsyslogd[   12.037795] audit: type=1400 audit(1515564630.515:5): avc:  denied  { syslog } for  pid=3348 comm="rsyslogd" capability=34  scontext=system_u:system_r:kernel_t:s0 tcontext=system_u:system_r:kernel_t:s0 tclass=capability2 permissive=1
+[?25l[?1c7[1G[[32m ok [39;49m8[?25h[?0c.
+Starting mcstransd: 
+[....] Starting periodic command scheduler: cron[?25l[?1c7[1G[[32m ok [39;49m8[?25h[?0c.
+[....] Starting file context maintaining daemon: restorecond[?25l[?1c7[1G[[32m ok [39;49m8[?25h[?0c.
+[....] Starting OpenBSD Secure Shell server: sshd[?25l[?1c7[1G[[32m ok [39;49m8[?25h[?0c.
+
+Debian GNU/Linux 7 syzkaller ttyS0
+
+syzkaller login: [   19.781382] audit: type=1400 audit(1515564638.259:6): avc:  denied  { map } for  pid=3488 comm="bash" path="/bin/bash" dev="sda1" ino=1457 scontext=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 tcontext=system_u:object_r:file_t:s0 tclass=file permissive=1
+Warning: Permanently added '10.128.0.54' (ECDSA) to the list of known hosts.
+net.ipv6.conf.syz0.accept_dad = 0
+net.ipv6.conf.syz0.router_solicitations = 0
+[   26.145521] audit: type=1400 audit(1515564644.623:7): avc:  denied  { map } for  pid=3502 comm="syzkaller898346" path="/root/syzkaller898346096" dev="sda1" ino=16481 scontext=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 tcontext=unconfined_u:object_r:user_home_t:s0 tclass=file permissive=1
+[   26.226655] audit: type=1400 audit(1515564644.704:8): avc:  denied  { map } for  pid=3502 comm="syzkaller898346" path="/dev/ashmem" dev="devtmpfs" ino=1065 scontext=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 tcontext=system_u:object_r:device_t:s0 tclass=chr_file permissive=1
+[   26.226985] 
+[   26.226987] ======================================================
+[   26.226988] WARNING: possible circular locking dependency detected
+[   26.226991] 4.15.0-rc7+ #255 Not tainted
+[   26.226992] ------------------------------------------------------
+[ 
diff --git a/syz-manager/manager.go b/syz-manager/manager.go
@@ -769,6 +769,11 @@ func (mgr *Manager) saveRepro(res *repro.Result, hub bool) {
 	}
 
 	if mgr.dash != nil {
+		// Note: we intentionally don't set Corrupted for reproducers:
+		// 1. This is reproducible so can be debugged even with corrupted report.
+		// 2. Repro re-tried 3 times and still got corrupted report at the end,
+		//    so maybe corrupted report detection is broken.
+		// 3. Reproduction is expensive so it's good to persist the result.
 		dc := &dashapi.Crash{
 			BuildID:     mgr.cfg.Tag,
 			Title:       res.Report.Title,