Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gometalinter: consider switching to golangci-lint #977

Closed
dvyukov opened this issue Feb 2, 2019 · 2 comments

Comments

Projects
None yet
1 participant
@dvyukov
Copy link
Collaborator

commented Feb 2, 2019

It's claimed to be 4.6x faster and consume 26% less memory:
https://github.com/golangci/golangci-lint

dvyukov added a commit that referenced this issue Mar 28, 2019

dvyukov added a commit that referenced this issue Mar 28, 2019

@dvyukov

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 28, 2019

dvyukov added a commit to dvyukov/syzkaller that referenced this issue Apr 23, 2019

all: fix some static analysis warnings
Fix warnings produced by golangci-lint.

Update google#977

dvyukov added a commit to dvyukov/syzkaller that referenced this issue Apr 23, 2019

dvyukov added a commit that referenced this issue Apr 23, 2019

all: fix some static analysis warnings
Fix warnings produced by golangci-lint.

Update #977

dvyukov added a commit that referenced this issue Apr 23, 2019

.golangci.yml: update
Enable more linters.
Tune settings for existings.
Fix excludes.

Update #977
@dvyukov

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 23, 2019

These issues are fixed now, but now I can't get memory consumption under control:
golangci/golangci-lint#509

dvyukov added a commit to dvyukov/syzkaller that referenced this issue May 15, 2019

.golangci.yml: add codeanalysis build tag
Using a build tag to exclude files for golangci-lint
reduces memory consumption (it does not parse them).
The naive attempt with skip-dirs did not work.
So add codeanalysis build tag and use it in auto-generated files.

Update google#977

dvyukov added a commit to dvyukov/syzkaller that referenced this issue May 15, 2019

dvyukov added a commit to dvyukov/syzkaller that referenced this issue May 15, 2019

.golangci.yml: add codeanalysis build tag
Using a build tag to exclude files for golangci-lint
reduces memory consumption (it does not parse them).
The naive attempt with skip-dirs did not work.
So add codeanalysis build tag and use it in auto-generated files.

Update google#977

dvyukov added a commit to dvyukov/syzkaller that referenced this issue May 15, 2019

dvyukov added a commit to dvyukov/syzkaller that referenced this issue May 15, 2019

.golangci.yml: add codeanalysis build tag
Using a build tag to exclude files for golangci-lint
reduces memory consumption (it does not parse them).
The naive attempt with skip-dirs did not work.
So add codeanalysis build tag and use it in auto-generated files.

Update google#977

dvyukov added a commit to dvyukov/syzkaller that referenced this issue May 15, 2019

dvyukov added a commit to dvyukov/syzkaller that referenced this issue May 15, 2019

dvyukov added a commit that referenced this issue May 15, 2019

.golangci.yml: add codeanalysis build tag
Using a build tag to exclude files for golangci-lint
reduces memory consumption (it does not parse them).
The naive attempt with skip-dirs did not work.
So add codeanalysis build tag and use it in auto-generated files.

Update #977

@dvyukov dvyukov closed this in 22c391e May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.