Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gometalinter: consider switching to golangci-lint #977

Closed
dvyukov opened this issue Feb 2, 2019 · 2 comments
Closed

gometalinter: consider switching to golangci-lint #977

dvyukov opened this issue Feb 2, 2019 · 2 comments

Comments

@dvyukov
Copy link
Collaborator

dvyukov commented Feb 2, 2019

It's claimed to be 4.6x faster and consume 26% less memory:
https://github.com/golangci/golangci-lint
dvyukov added a commit that referenced this issue Mar 28, 2019
@dvyukov
all: fix warnings pointed to by golangci-lint
4a9fce1 
Update #977
dvyukov added a commit that referenced this issue Mar 28, 2019
@dvyukov
.golangci.yml: add golangci-lint config
14c58f8 
Update #977
@dvyukov
Copy link
Collaborator Author

dvyukov commented Mar 28, 2019

So far I couldn't make golangci-lint to work. Filed:
golangci/golangci-lint#466
golangci/golangci-lint#467
golangci/golangci-lint#468
golangci/golangci-lint#469

@dvyukov dvyukov mentioned this issue Apr 4, 2019
Closed
dvyukov added a commit to dvyukov/syzkaller that referenced this issue Apr 23, 2019
@dvyukov
all: fix some static analysis warnings
74231c7 
Fix warnings produced by golangci-lint.

Update google#977
dvyukov added a commit to dvyukov/syzkaller that referenced this issue Apr 23, 2019
@dvyukov
Makefile: switch to golangci-lint
1f718f1 
Update google#977
dvyukov added a commit that referenced this issue Apr 23, 2019
@dvyukov
all: fix some static analysis warnings
8095117 
Fix warnings produced by golangci-lint.

Update #977
dvyukov added a commit that referenced this issue Apr 23, 2019
@dvyukov
.golangci.yml: update
51fc038 
Enable more linters.
Tune settings for existings.
Fix excludes.

Update #977
@dvyukov
Copy link
Collaborator Author

dvyukov commented Apr 23, 2019

These issues are fixed now, but now I can't get memory consumption under control:
golangci/golangci-lint#509

@dvyukov dvyukov mentioned this issue May 3, 2019
Closed
dvyukov added a commit to dvyukov/syzkaller that referenced this issue May 15, 2019
@dvyukov
.golangci.yml: add codeanalysis build tag
69a0dbe 
Using a build tag to exclude files for golangci-lint
reduces memory consumption (it does not parse them).
The naive attempt with skip-dirs did not work.
So add codeanalysis build tag and use it in auto-generated files.

Update google#977
dvyukov added a commit to dvyukov/syzkaller that referenced this issue May 15, 2019
@dvyukov
Makefile: switch to golangci-lint
8949231 
Finally!

Fixes google#977
dvyukov added a commit to dvyukov/syzkaller that referenced this issue May 15, 2019
@dvyukov
.golangci.yml: add codeanalysis build tag
a2a2c1a 
Using a build tag to exclude files for golangci-lint
reduces memory consumption (it does not parse them).
The naive attempt with skip-dirs did not work.
So add codeanalysis build tag and use it in auto-generated files.

Update google#977
dvyukov added a commit to dvyukov/syzkaller that referenced this issue May 15, 2019
@dvyukov
Makefile: switch to golangci-lint
2934b68 
Finally!

Fixes google#977
Fixes google#1108
dvyukov added a commit that referenced this issue May 15, 2019
@dvyukov
.golangci.yml: add codeanalysis build tag
01d1494 
Using a build tag to exclude files for golangci-lint
reduces memory consumption (it does not parse them).
The naive attempt with skip-dirs did not work.
So add codeanalysis build tag and use it in auto-generated files.

Update #977
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dvyukov