Converge (just a little) the Stub and Serve traits #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This streamlines the Stub and Serve traits: - Serve::method is removed - Stub::call's request_name parameter is removed. The tarpc-generated request types implement RequestName, and there are a few convenience implementations for std types.
They now exist on an extension trait called RequestHook.
In an interesting twist, it turns out that all tarpc services can also act as client stubs. This makes sense intuitively: a stub just sends a request to a service and waits to receive a response; if you already have a service, you can simply cut out the middleman. I'm not really sure when this would be useful. Has science gone too far? Maybe it could be used to more easily mock out backends in unit tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we'll ever completely unify these two traits, since one takes self by reference and one by value. However, we can actually get pretty close and have
Serve + Clonetypesimpl Stub. I don't remember the original motiviation of #251, but I think there are probably more use cases for services acting as Stubs than vice versa.Fixes #251