Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Release/2.0 #56

Merged
merged 31 commits into from Nov 4, 2020
Merged

Release/2.0 #56

merged 31 commits into from Nov 4, 2020

Conversation

cfezequiel
Copy link
Contributor

@cfezequiel cfezequiel commented Nov 2, 2020

Description

Additional features and API update.
See Release 2.0 in ../RELEASE.md for details.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix/feature that may cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Please delete options that are not relevant.

  • My code adheres to the Google Python Style Guide
  • I ran make pylint and code is rated 10/10
  • I have added tests that prove my fix is effective or that my feature works
  • I ran make test and all tests pass
  • I ran the tool and verified the change works
  • I have adequately commented my code, particularly in hard-to-understand areas
  • I have made relevant changes to the documentation, if needed
  • My changes generate no new warnings
  • I have corrected any misspellings in my code
  • (For hotfix/release) I have updated the package version number in setup.py (i.e. MAJOR.MINOR.PATCH)
  • (For hotfix/release) I have updated RELEASE.md with notes regarding the changes

cfezequiel and others added 30 commits October 7, 2020 12:58
Update check_tfrecords to use new dataset load function.
* Added data classes for types.

* Checking in progress.

* Checking in more changes.

* Converted types to classes and refactored schema into OO pattern.

* Changed OrderedDict import to support py3.6.

* Changed OrderedDict import to support py3.6.

* Updated setup.py for version.

* fixing setup.py

* Patched requirements and setup.

* Addressed comments in code review.

* Addressed code comments round 2.

* refactored IMAGE_CSV_SCHEMA.

* Merged check_test.py from dev

Co-authored-by: Carlos Ezequiel <cezequiel@google.com>
* Converted types to classes and refactored schema into OO pattern.

* Add tutorial on structured data conversion.

This changes types.FloatInput to use tf.float32 for its feature_spec
attribute to address potential incompatibility with using tf.float64
type in TensorFlow Transform.

Co-authored-by: Mike Bernico <mikebernico@google.com>
* Restructure test image directory to match expected format.

* Clean up README and update image directory notebook.
Minor fixes + explicit error when no training split found
Configure automated tests for Jupyter notebooks.
Also refactor create_tfrecords to convert.
* Add convert_and_load function.

Also refactor create_tfrecords to convert.

* Refactor check and common modules to utils.

* Add test targets for py files and notebooks.
@google-cla
Copy link

google-cla bot commented Nov 2, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Nov 2, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Nov 2, 2020

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@cfezequiel
Copy link
Contributor Author

@lc0 fyi. This is a PR to merge changes from the dev branch, which includes your PR, to master. Please review the google-cla comment above. I've set the cla: yes label since we already merged your PR to dev.

@mbernico mbernico merged commit f4650ca into master Nov 4, 2020
@lc0
Copy link
Contributor

lc0 commented Nov 4, 2020

@cfezequiel sure, I did sign SLA on other projects within google/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants