Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor, adding version info and minor bug fixes #1248

Merged
merged 6 commits into from Jun 3, 2020

Conversation

kiddinn
Copy link
Contributor

@kiddinn kiddinn commented Jun 3, 2020

Few things done in this PR

  1. Updating the version information for numpy/pandas/altair to match a more recent version (also to cut time on compiling needed for ubuntu 20.04
  2. bug fix ExploreResource now checks whether an index is in a ready state before it is added to the search, so if _all is used as an index, timelines in an error state or other states are not included in the search
  3. bug fix A new error condition is handled in utils.py where an attempt is made to create an index that already exists (in the case where an importer is importing a file in chunks)
  4. Timesketch version information is moved out of setup.py into a separate file
  5. The Timesketch Version information is now included in the metadata of a sketch export.
  6. When a timeline is added to a sketch all sketch labels that are deemed "protected" are propagated to the timeline and search index (to prevent deletion)
  7. Various bug fixes in the API client and resources to deal with handling an archived sketch.
  8. Changing the way sketches are archived to be a status instead of a label

@kiddinn kiddinn changed the title Minor enhancements Moving __init__ to app, adding version information and bug fixes Jun 3, 2020
@kiddinn kiddinn changed the title Moving __init__ to app, adding version information and bug fixes Moved __init__ to app, adding version information and bug fixes Jun 3, 2020
@kiddinn kiddinn requested a review from berggren June 3, 2020 14:24
@kiddinn kiddinn marked this pull request as ready for review June 3, 2020 14:24
Copy link
Contributor

@berggren berggren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berggren berggren changed the title Moved __init__ to app, adding version information and bug fixes Refactor, adding version info and minor bug fixes Jun 3, 2020
@berggren berggren merged commit b78f295 into google:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants