Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Timesketch output module to work with upcoming version of Timesketch #3005

Merged
merged 4 commits into from Jun 5, 2020
Merged

Updated Timesketch output module to work with upcoming version of Timesketch #3005

merged 4 commits into from Jun 5, 2020

Conversation

kiddinn
Copy link
Member

@kiddinn kiddinn commented Jun 5, 2020 •
edited by joachimmetz

One line description of pull request

After google/timesketch#1248 in Timesketch the create_app no longer resides in timesketch module, but rather inside the timesketch.app module.

This PR fixes that.

Description:

Related issue (if applicable): fixes google/timesketch#1254

Checklist:

  • Automated checks (Travis, Codecov, Codefactor )pass
  • No new new dependencies are required or l2tdevtools has been updated
  • Reviewer assigned

@kiddinn kiddinn added the bug label Jun 5, 2020
@kiddinn kiddinn marked this pull request as ready for review June 5, 2020 09:09
@kiddinn kiddinn requested a review from joachimmetz June 5, 2020 09:09
joachimmetz
joachimmetz approved these changes Jun 5, 2020
View reviewed changes
Copy link
Member

@joachimmetz joachimmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll merge once the CI tests pass

@joachimmetz joachimmetz added to merge Issue has been reviewed and can be merged when checks are complete and removed bug labels Jun 5, 2020
@joachimmetz joachimmetz changed the title Minor bug fix in the TS output module. Updated the Timesketch output module to work with upcoming version of Timesketch Jun 5, 2020
@joachimmetz joachimmetz changed the title Updated the Timesketch output module to work with upcoming version of Timesketch Updated Timesketch output module to work with upcoming version of Timesketch Jun 5, 2020
@joachimmetz joachimmetz removed the to merge Issue has been reviewed and can be merged when checks are complete label Jun 5, 2020
@joachimmetz joachimmetz merged commit ca40656 into log2timeline:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachimmetz joachimmetz joachimmetz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Psort ingestion error 'no attribute create_app'
2 participants
@kiddinn @joachimmetz