-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sigma api e2e #1730
Sigma api e2e #1730
Conversation
… variable is called id
add initiatl e2e tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly comments on the notebook
I'm also missing some more text in the notebook, some further explanations on what is happening, why, what you are trying to achieve, etc, etc, etc. |
Good point, added a littel more text of what is going on, hope that helps. |
Not sure why the tests are currently only queued I tried to restart them, but the changes since last run only affected the notebook. |
don't worry about that... there is a build-up queue in the GH actions for the google org, so that's why it's taking some time. I cancelled all your runs, since I'll need to re-sync with master. I'll do that once the queue has caught up with all the currently running GH actions in the TS repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few more comments
ready for next round of review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, almost there, just small nits and then we are good to go
The nits have been knitted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sigma 2e2 stuff, some other fixed in the api client and a Sigma Notebook