Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left panel timeline management #2999

Merged
merged 22 commits into from Dec 5, 2023

Conversation

Annoraaq
Copy link
Collaborator

@Annoraaq Annoraaq commented Dec 1, 2023

Much of the diff stems from Pulling out a generic TimelineComponent that provides slots to customize the template. It can now be used to display chips (TimelineChip) or table rows (used inside TimelinesTable).
I also added a slot to the UploadForm component to make it more generic and not restrict its usage to buttons. The specific one is now called (UploadFormButton).

@Annoraaq Annoraaq requested a review from jkppr December 4, 2023 09:01
@Annoraaq Annoraaq marked this pull request as ready for review December 4, 2023 09:08
@jkppr jkppr changed the title Timelines left panel iteration 1 Left panel timeline management Dec 4, 2023
@jkppr jkppr added the Frontend label Dec 4, 2023
@jkppr jkppr added this to the Release: 20231206 milestone Dec 4, 2023
Copy link
Collaborator

@jkppr jkppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this great feature. I fixed some minor UI stuff myself but please take a look at the following comments.

@Annoraaq Annoraaq requested a review from jkppr December 5, 2023 09:02
@berggren
Copy link
Contributor

berggren commented Dec 5, 2023

Drive-by comment: We use two different styles for search input in the left panel.

  1. Let's stay consistent and choose one. Personally I like the old one with a bit less padding around.
  2. Maybe hide the search if number of timelines is less then perhaps <5 ?
Screenshot 2023-12-05 at 10 27 42

@berggren
Copy link
Contributor

berggren commented Dec 5, 2023

  1. Do we need the horizontal line? IMO it adds a bit of unnecessary clutter.
  2. Maybe reduce the size of the "Timelines" title? It's a bit out of place, font size wise.
Screenshot 2023-12-05 at 10 43 24

@jkppr
Copy link
Collaborator

jkppr commented Dec 5, 2023

Thanks for the input @berggren . I have included your recommended changes in this PR.

Copy link
Collaborator

@jkppr jkppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks for this great feature!

@jkppr jkppr merged commit 33bd484 into google:master Dec 5, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Timeline Management
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants