Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the analyzer timeline picker #3001

Merged
merged 2 commits into from Dec 6, 2023

Conversation

jkppr
Copy link
Collaborator

@jkppr jkppr commented Dec 6, 2023

Closing issues
closes #2774

@jkppr jkppr added this to the Release: 20231206 milestone Dec 6, 2023
@jkppr jkppr requested a review from Annoraaq December 6, 2023 10:33
@jkppr jkppr self-assigned this Dec 6, 2023
@berggren
Copy link
Contributor

berggren commented Dec 6, 2023

UI feedback. When there are a few timelines the controls are hidden (good). The padding is out of place though. Please align with the other components.

Screenshot 2023-12-06 at 11 35 08

@jkppr
Copy link
Collaborator Author

jkppr commented Dec 6, 2023

Fixed

image

Copy link
Collaborator

@Annoraaq Annoraaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkppr jkppr merged commit a3a214c into google:master Dec 6, 2023
24 checks passed
@jkppr jkppr deleted the 2774_analyzer_timeline_chips branch December 6, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign of timeline chips in the new UI
3 participants