-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: default Vagrant images are hosted on vagrantcloud #545
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Hi there! What is it that you're hoping to fix with this PR? |
@adamjnichols As vagrant changed the distribution model of the default Vagrant boxes: hashicorp/vagrant#9442 this allows to use the Vagrant installation. |
CLAs look good, thanks! |
I'm aware of that issue, but it doesn't stem from Hashi changing the way they distribute, so much as their acknowledgement of a bug affecting Vagrant installs < 1.9.6 when the metadata URLs were changed. It seems they pulled redirects too early, and a fix will be forthcoming. I'm not sure we want to make downstream changes for something we expect they will address in the near-term. @berggren thoughts? |
@adamjnichols I tested with various version of Vagrant including latest, it works with the new distribution path. FYI, I wanted to be sure that I could build timesketch and MISP (misp-vagrant) together. |
I'm sure it works great, they seem to list it as a work around. My concerns have more to do with changing our Vagrantfile to address a problem that only affects a subset of Vagrant installs, and is something Hashi has already accepted as a bug (meaning they intend to fix). |
Thanks @adulau for filing this PR. I agree with Adam here in that we should not change out Vagrant file to add this workaround. Let's monitor the upstream bug and if they decide not to fix this we can open this PR again. |
No description provided.