Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default Vagrant images are hosted on vagrantcloud #545

Closed
wants to merge 1 commit into from
Closed

fix: default Vagrant images are hosted on vagrantcloud #545

wants to merge 1 commit into from

Conversation

adulau
Copy link

@adulau adulau commented Feb 17, 2018

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@adamjnichols
Copy link
Contributor

Hi there! What is it that you're hoping to fix with this PR?

@adulau
Copy link
Author

adulau commented Feb 18, 2018

@adamjnichols As vagrant changed the distribution model of the default Vagrant boxes: hashicorp/vagrant#9442 this allows to use the Vagrant installation.

@googlebot
Copy link

CLAs look good, thanks!

@adamjnichols
Copy link
Contributor

I'm aware of that issue, but it doesn't stem from Hashi changing the way they distribute, so much as their acknowledgement of a bug affecting Vagrant installs < 1.9.6 when the metadata URLs were changed. It seems they pulled redirects too early, and a fix will be forthcoming. I'm not sure we want to make downstream changes for something we expect they will address in the near-term.

@berggren thoughts?

@adulau
Copy link
Author

adulau commented Feb 18, 2018

@adamjnichols I tested with various version of Vagrant including latest, it works with the new distribution path. FYI, I wanted to be sure that I could build timesketch and MISP (misp-vagrant) together.

@adamjnichols
Copy link
Contributor

I'm sure it works great, they seem to list it as a work around. My concerns have more to do with changing our Vagrantfile to address a problem that only affects a subset of Vagrant installs, and is something Hashi has already accepted as a bug (meaning they intend to fix).

@berggren
Copy link
Contributor

Thanks @adulau for filing this PR. I agree with Adam here in that we should not change out Vagrant file to add this workaround. Let's monitor the upstream bug and if they decide not to fix this we can open this PR again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants