This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Fix failing performace tests #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Track contents drawing function is draw_() instead of drawTrackContents_(). Call to invalid function drawTrackContents_() is causing failure of performance tests: tracing.tracks.drawing_container_perf_test.draw_softwareCanvas_1 tracing.tracks.drawing_container_perf_test.draw_softwareCanvas_10 tracing.tracks.drawing_container_perf_test.draw_softwareCanvas_100 drawTrackContents_() was renamed to draw_() as part of revision 1544 - Add collapsing to most tracks in the timeline [1] https://code.google.com/p/trace-viewer/source/diff?spec=svn1544&r=1544&format=side&path=/trunk/trace_viewer/tracing/tracks/drawing_container.html R=dsinclair@chromium.org
This was referenced Sep 22, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track contents drawing function is draw_() instead of drawTrackContents_().
Call to invalid function drawTrackContents_() is causing failure of performance tests:
tracing.tracks.drawing_container_perf_test.draw_softwareCanvas_1
tracing.tracks.drawing_container_perf_test.draw_softwareCanvas_10
tracing.tracks.drawing_container_perf_test.draw_softwareCanvas_100
drawTrackContents_() was renamed to draw_() as part of revision 1544 - Add collapsing to most tracks in the timeline
[1] https://code.google.com/p/trace-viewer/source/diff?spec=svn1544&r=1544&format=side&path=/trunk/trace_viewer/tracing/tracks/drawing_container.html
R=dsinclair@chromium.org