Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI: Test on Node.js v4.x.x and v5.x.x #2050

Closed
wants to merge 2 commits into from

Conversation

SrinivasanTarget
Copy link
Contributor

No description provided.

@arv
Copy link
Collaborator

arv commented Dec 30, 2015

What is the motivation of this? I can see a few reasons but I would like to know yours?

The downside of doing this is that it takes longer before we know the results...

@SrinivasanTarget
Copy link
Contributor Author

@arv I don't think it will take sometime to know the results as CI took very less time to update the results back. Also i feel it would be always great to test features not only on latest stable version and also the stable versions that are widely used. Please let me know your thoughts.

@SrinivasanTarget
Copy link
Contributor Author

@arv ping

@arv
Copy link
Collaborator

arv commented Jan 18, 2016

LGTM

@SrinivasanTarget Did you sign the CLA? Can you add yourself to AUTHORS?

@johnjbarton Can you check the clasigners (I can no longer access it)?

@SrinivasanTarget
Copy link
Contributor Author

Please let me know how to sign CLA?
On 18-Jan-2016 6:27 am, "Erik Arvidsson" notifications@github.com wrote:

LGTM

@SrinivasanTarget https://github.com/SrinivasanTarget Did you sign the
CLA? Can you add yourself to AUTHORS?

@johnjbarton https://github.com/johnjbarton Can you check the
clasigners (I can no longer access it)?


Reply to this email directly or view it on GitHub
#2050 (comment)
.

@arv
Copy link
Collaborator

arv commented Jan 18, 2016

@SrinivasanTarget
Copy link
Contributor Author

I have signed the CLA.

@SrinivasanTarget
Copy link
Contributor Author

@arv @johnjbarton updated in author list as well.

@arv
Copy link
Collaborator

arv commented Jan 18, 2016

LGTM

@SrinivasanTarget
Copy link
Contributor Author

@arv @johnjbarton Can you merge ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants