This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Adding a simple benchmark runner HTML page and node script. #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| benchmark.register('simple', function() { | ||
| var scope = wtf.trace.enterScope(); | ||
| var x = 0; | ||
| x++; |
There was a problem hiding this comment.
Not sure if it matters, but this seems to have high probability of being optimized out completely (the business with x). Maybe take a, b and return a+b or something?
There was a problem hiding this comment.
Good idea. I'm totally going to make you do a review of all this once you've got some time - I've tried to make it so that we can easily get hydrogen dumps of the runs via node's v8 opts, though I haven't tested that yet. The benchmark.js runner can do whatever it wants to the methods before they run, too, if we need to inject big comment blocks/etc.
|
lgtm |
This runs the benchmarks/simple.js file with benchmarkjs and outputs the results. More benchmarks can be added manually. In the future update-benchmarks.sh will update the listing.
benvanik
added a commit
that referenced
this pull request
Dec 14, 2012
Adding a simple benchmark runner HTML page and node script.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs the benchmarks/simple.js file with benchmarkjs and outputs the
results. More benchmarks can be added manually. In the future
update-benchmarks.sh will update the listing.