Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new optional fields for Text-to-Speech functionality in Service Alerts feed #135

Merged

Conversation

ibi-group-team
Copy link
Contributor

@ibi-group-team ibi-group-team commented Jan 10, 2019

This is a proposal to add two new optional fields for text-to-speech functionality to the ServiceAlerts feed, called tts_header_text and tts_description_text of type TranslatedString.

See discussion here: #132

Announced on the GTFS-realtime Google Groups here: https://groups.google.com/forum/#!topic/gtfs-realtime/aI7OfMycsHw

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@ibi-group-team
Copy link
Contributor Author

ibi-group-team commented Jan 10, 2019 via email

@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@farah-machlab-ibigroup
Copy link

I'm a commit author and I'm ok with my commits being contributed to this project.

@LeoFrachet
Copy link
Contributor

I agree with the fields, their names and their definitions.

Two small suggestions:

  1. Add the space missing in second definition: //Text => // Text
  2. Maybe something (an example or a guideline) could be added to describe what they'll contain. For information in my tts_stop_name proposal (Add fields for text-to-speech #49), I was offering this kind of definition for text-to-speech field, to help the reader understand what would be the difference of content:
  • Text-to-speech field - The field should contain the same information than its parent field (on which it falls back if it is empty). It is aimed to be read as text-to-speech, therefore, abbreviation should be either removed ("St" should be either read as "Street" or "Saint"; "Elizabeth I" should be "Elizabeth the first") or kept to be read as it ("JFK Airport" is said abbreviated).

@ibi-group-team
Copy link
Contributor Author

This pull request has been open for more than one week, so we are calling for a vote.

Voting will be closed on Tuesday January 29 at 23:59:59 UTC.

@abyrd
Copy link

abyrd commented Jan 22, 2019

+1

@ibi-group-team ibi-group-team changed the title Add new optional field for Text-to-Speech functionality in Service Alerts feed: tts_ivr Add new optional fields for Text-to-Speech functionality in Service Alerts feed Jan 22, 2019
@LeoFrachet
Copy link
Contributor

+1

Pinging:

@gcamp
Copy link
Contributor

gcamp commented Jan 22, 2019

(That was a +1)

@paulswartz
Copy link
Contributor

+0. We don't have a problem with this field, but aren't likely to incorporate it into how we use Text-to-speech for alerts.

@barbeau
Copy link
Collaborator

barbeau commented Jan 23, 2019

@ibi-group-team One point of clarity - I believe this vote is for adopting the tts fields as "experimental", right? In that case you'll need to mark it as experimental (for an example, see OccupancyStatus - https://github.com/google/transit/blob/master/gtfs-realtime/spec/en/reference.md#enum-occupancystatus)

I'm +1 for adopting as experimental field.

@ibi-group-team
Copy link
Contributor Author

Voting for this proposal is closed and the results are:
Yes: 4
No: 0

So the proposal passes! We'll get this merged.

Thank you all!

@ibi-group-team
Copy link
Contributor Author

@google-admin @googlebot the CLA check is currently failing so this cannot be merged. @farah-machlab-ibigroup's contributions are covered under the corporate CLA for IBI Group. Can you please confirm and update the check?

@googlebot
Copy link
Collaborator

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@barbeau barbeau added the GTFS Realtime Issues and Pull Requests that focus on GTFS Realtime label Feb 1, 2019
@barbeau
Copy link
Collaborator

barbeau commented Feb 1, 2019

Thanks @ibi-group-team and all for coming to a consensus on this!

@barbeau barbeau merged commit 2538470 into google:master Feb 1, 2019
@ibi-group-team ibi-group-team deleted the ServiceAlerts-add-tt_ivr-field branch February 1, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GTFS Realtime Issues and Pull Requests that focus on GTFS Realtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants