Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better cross-linking for PR and Google Groups post #35

Merged
merged 1 commit into from
Jan 30, 2017

Conversation

barbeau
Copy link
Collaborator

@barbeau barbeau commented Dec 21, 2016

A proposal for improved communication regarding the Github/Google Groups workflow for the Change process:

  • Make sure each has a link to the other
  • Announce the PR result (accepted or abandoned) in the same Google Group thread

First mentioned in #30 (comment).

Announced on GTFS Changes Google Group at https://groups.google.com/forum/#!topic/gtfs-changes/bqXHRIBdP4E.

cc @mmorang

* Make sure each has a link to the other
* Announce the PR result (accepted or abandoned) in the same Google Group thread
@mmorang
Copy link

mmorang commented Dec 21, 2016

+1 (if we're voting...?)

@barbeau
Copy link
Collaborator Author

barbeau commented Dec 21, 2016

@mmorang I believe we'd need to follow standard protocol on this proposal as well, so it would be the same 7 day period for comments, etc. specified in https://github.com/google/transit/blob/master/gtfs/CHANGES.md#specification-amendment-process.

@RachM
Copy link
Contributor

RachM commented Jan 9, 2017

+1

@barbeau
Copy link
Collaborator Author

barbeau commented Jan 10, 2017

Sorry, the holidays got me on this one - I should have called for a vote earlier. At any rate, I'd like to officially call for a vote now given its at least 7 days after the proposal. Technically any votes prior to the call for vote don't count, so @RachM and @mmorang if you wouldn't mind expressing your support again that would be great! Thanks!

@RachM
Copy link
Contributor

RachM commented Jan 10, 2017

+1 :)

@mmorang
Copy link

mmorang commented Jan 10, 2017

+1 again.

@skinkie
Copy link
Contributor

skinkie commented Jan 10, 2017

+1 missed this :)

@barbeau
Copy link
Collaborator Author

barbeau commented Jan 10, 2017

I also should have announced that the voting period will end on Jan 16th at 23:59:59 UTC. We're all still getting used to this :).

@mmorang
Copy link

mmorang commented Jan 10, 2017

Incidentally, someone from a transit agency whose job is to update their gtfs feed recently asked me about how to keep up with changes to GTFS, and I told him about the gtfs-changes e-mail list. He was completely unaware of it. He asked if Google tells feed producers about the list. Does Google do this? If not, how can we be sure that feed producers are actually informed about updates and are aware of the proposal procedure?

@skinkie
Copy link
Contributor

skinkie commented Jan 10, 2017 via email

@laurentg
Copy link

+1

5 similar comments
@DaveBarker
Copy link

+1

@antrim
Copy link
Contributor

antrim commented Jan 11, 2017

+1

@fpurcell
Copy link

+1

@drewda
Copy link

drewda commented Jan 13, 2017

+1

@LeoFrachet
Copy link
Contributor

+1

@barbeau
Copy link
Collaborator Author

barbeau commented Jan 20, 2017

Alright, looks like the voting period is over, and we have many +1s and no votes against. So, this can be merged! I'll post to the list after the merge is complete announcing it.

@barbeau
Copy link
Collaborator Author

barbeau commented Jan 27, 2017

@zhsh could you please merge this?

@dbabramov dbabramov merged commit 70a80a9 into google:master Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet