[Serverless] Add distributor action #467
Conversation
| distributor on GitHub too. | ||
|
|
||
| For more details on witnessing, and the various roles involved (including | ||
| `distributor`), please see the [witness README](/google/trillian-examples/witness) |
There was a problem hiding this comment.
Fair warning: at least in the github preview this link does not work as expected - it takes me to https://github.com/google/trillian-examples/blob/master/google/trillian-examples/witness
There was a problem hiding this comment.
hehe, too clever :)
done.
| 2. Initialise the distributor state: | ||
| 1. we'll use a directory called `distributor` in our repo to | ||
| store the state files | ||
| 2. TODO: config file |
There was a problem hiding this comment.
Is this TODO for now, or a real TODO later?
There was a problem hiding this comment.
I kinda TODONE it, linked to the example config
| Now you can raise "incoming checkpoint" PRs which drop cosigned checkpoints into the | ||
| `distributor/logs/<log_id>/incoming` directory, whereupon the `witness_validator` action | ||
| should check the contents. Once the "incoming checkpoint" PRs are merged you | ||
| should see the `combine_witness_signs` action running in response (check the |
There was a problem hiding this comment.
| should see the `combine_witness_signs` action running in response (check the | |
| should see the `combine_witness_signatures` action running in response (check the |
|
|
||
| PRs containing cosigned checkpoint files under the log's `.../witness` directory are | ||
| PRs containing cosigned checkpoint files under the distributor's `logs/<logID>/incoming` directory are |
There was a problem hiding this comment.
| PRs containing cosigned checkpoint files under the distributor's `logs/<logID>/incoming` directory are | |
| PRs containing cosigned checkpoint files under the distributor's `distributor/logs/<logID>/incoming` directory are |
There's a configurable directory that works as the root. Not sure if including it makes it more correct or just confusing.
There was a problem hiding this comment.
Ah yes, I've used ellipsis elsewhere to suggest that this is internal structure to a defined directory, so I've added that here too - ta!
| "golang.org/x/mod/sumdb/note" | ||
| ) | ||
|
|
||
| // UpdateOpts contains the settings for the distributor update. |
There was a problem hiding this comment.
Something in this file needs to be clearer that while a distributor handles many logs, this update is processed/sharded per log.
There was a problem hiding this comment.
yeah, good call - modified the UpdateState comment to reflect that.
| // Handle changes in number of required CPs | ||
| requiredSlots := int(opts.MaxWitnessSignatures + 1) | ||
| if l := len(state); l > requiredSlots { | ||
| state = state[0:requiredSlots] |
There was a problem hiding this comment.
| state = state[0:requiredSlots] | |
| state = state[:requiredSlots] |
| ret[i] = nil | ||
| } | ||
| return ret, nil | ||
|
|
Update serverless witness actions to be a distributor
Part of #464