Use int64 in memoryMerkleTree #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdbelvin
force-pushed
the
merkle
branch
2 times, most recently
from
b84f1e9
to
01fb5cc
Compare
|
Can you investigate the travis failure first. |
|
The Travis failure needs to be fixed by a more comprehensive refactor of the NewLogStorage API. |
|
Fixing the tests should be the priority to avoid introducing additional issues. |
|
Fixing in #327 |
|
The tests are passing now. Is this PR ready to go? |
|
I looked at it yesterday. I'll have another look later today.
…On 27 January 2017 at 09:35, Gary Belvin ***@***.***> wrote:
The tests are passing now. Is this PR ready to go?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#321 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AMv2T0B8SXcZ5qPXM_kszJv1idEhSrTMks5rWbpbgaJpZM4LtYMd>
.
|
Martin2112
approved these changes
Jan 27, 2017
|
I'm adding a proper LogVerifier next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR in preparation for building a LogVerifier.
We need a common set of tree functions to use in the
merklepackage