Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests #327

Closed
wants to merge 2 commits into from
Closed

Fix integration tests #327

wants to merge 2 commits into from

Conversation

gdbelvin
Copy link
Contributor

This is a temporary hack to get the integration tests running again while #324 is being worked on.

Create databases before using them

  • Creates connection test tree 0 on db reset
  • Creates trees for integration tests

@@ -8,5 +8,8 @@ then
mysql -u root "$@" -e 'CREATE DATABASE test;'
mysql -u root "$@" -e "GRANT ALL ON test.* TO 'test'@'localhost' IDENTIFIED BY 'zaphod';"
mysql -u root "$@" -D test < storage/mysql/storage.sql
#TODO(codeinglama): remove when db connection check doesn't ping log 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelt @codingllama

@@ -8,5 +8,8 @@ then
mysql -u root "$@" -e 'CREATE DATABASE test;'
mysql -u root "$@" -e "GRANT ALL ON test.* TO 'test'@'localhost' IDENTIFIED BY 'zaphod';"
mysql -u root "$@" -D test < storage/mysql/storage.sql
#TODO(codeinglama): remove when db connection check doesn't ping log 0
mysql -u root "$@" -D test -e "INSERT INTO Trees VALUES (0,1,'LOG','SHA256','SHA256',false)"
mysql -u root "$@" -D test -e "INSERT INTO TreeControl VALUES (0,false,false,false,1,1)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be done by just invoking createlog.sh 0 ?

@daviddrysdale
Copy link
Contributor

Would you expect Travis to work yet?

@gdbelvin
Copy link
Contributor Author

This resolves the row missing errors. Travis may still fail due to too many DB connections at once.

@gdbelvin
Copy link
Contributor Author

Rebased on @codingllama 's #326 to include the DB connections fix so Travis will pass.

- Creates connection test tree 0 on db reset
- Creates trees for integration tests
@daviddrysdale
Copy link
Contributor

Pull #328 seemed to fix things so has gone in....

@gdbelvin gdbelvin closed this Jan 26, 2017
@gdbelvin gdbelvin deleted the fix-int branch July 4, 2017 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants