Skip to content

Commit

Permalink
Make check() final.
Browse files Browse the repository at this point in the history
No one overrides it, and no one should.

RELNOTES=Made `StandardSubjectBuilder.check()` final.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=179961554
  • Loading branch information
cpovirk authored and ronshapiro committed Dec 28, 2017
1 parent cc98d44 commit 1d44b58
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions core/src/main/java/com/google/common/truth/Subject.java
Original file line number Diff line number Diff line change
Expand Up @@ -339,8 +339,7 @@ protected String actualCustomStringRepresentation() {
* ThrowableSubject#hasMessageThat} is implemented with {@code
* check().that(actual().getMessage()}, which returns a {@link StringSubject}.
*/
// TODO(diamondm) this should be final, can we do that safely?
protected StandardSubjectBuilder check() {
protected final StandardSubjectBuilder check() {
return new StandardSubjectBuilder(metadata);
}

Expand Down

0 comments on commit 1d44b58

Please sign in to comment.