Rename our type parameter so that we define assertThat(ComparableT actual) instead of assertThat(T actual).
#1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_518905622
branch
from
19a6c3d
to
38f7123
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename our type parameter so that we define
assertThat(ComparableT actual)instead ofassertThat(T actual).This might be a little silly to wory about, but I think it makes much clearer what the method is for when you're looking at a list of
assertThatmethods. Compare the Javadoc forTruth.assertThat, which this CL is changing, to the Javadoc forStandardSubjectBuilder.that, which has been usingComparableTfor years (for exactly this reason):(Aside: All the appearances of fully qualified "java.lang.Boolean" and so forth are a shame....)
RELNOTES=n/a