Merge changes from google3 #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Fixes #164 ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=88212495
…nullable, like the Object first and second arguments. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=88747371
… the actual value be the subject of the assertion. Also tidy up some of the formatting as a drive-by. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=89284234
…elements don't implement hashCode() (e.g., ProtoBuf's MessageSet!) This at least partially addresses #176 ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=89605122
------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=90543365
Add a test that makes sure all assertThat() overloads accept null and do the right thing for isNull(), isNotNull(), isEqualTo(), and isNotEqualTo(). ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=90551205
…here we know isEqualTo is the better option). @deprecate isEqualTo and isNotEqualTo on DoubleSubject. Add tests for pass null to ComparableSubject. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=90636937
------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=90811709
Add missing @nullable annotatinos to TableSubject. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=90840494
Add missing @nullable annotations to MapSubject. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=90850969
…EqualTo(). ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=91308469
------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=91438032
------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=91592303
------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=91722692
…ld be prefer over isEquivalentAccordingToCompareTo(). ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=91807574
------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=91877928
cgruber
force-pushed
the
merge_from_google3
branch
from
b027124
to
82ae4db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.