Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies and switch to nullsafety #24

Merged
merged 3 commits into from
Nov 25, 2020
Merged

Update dependencies and switch to nullsafety #24

merged 3 commits into from
Nov 25, 2020

Conversation

Wikiwix
Copy link
Contributor

@Wikiwix Wikiwix commented Nov 21, 2020 •
edited
Loading

Due to the nature of the package the actual library code is already nullsafe and unchanged.
The only necessary changes are

  • the dependency,
  • SDK constraint,
  • unit tests regarding null and
  • the travis CI config, so that it uses the current beta instead of dart 2.2.

@google-cla
Copy link

google-cla bot commented Nov 21, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@Wikiwix
Update dependencies and switch to nullsafety
f67a2d7 
Due to the nature of the package the actual code is already nullsafe.
The only changes necessary are unit tests
checking for throwing errors on null.
@Wikiwix
Copy link
Contributor Author

Wikiwix commented Nov 21, 2020

@googlebot I fixed it.

@Wikiwix Wikiwix marked this pull request as ready for review November 21, 2020 20:19
@mit-mit
Copy link
Member

mit-mit commented Nov 25, 2020

cc @kevmoo

@kevmoo
Copy link
Collaborator

kevmoo commented Nov 25, 2020

@mit-mit – should I land this?

@mit-mit
Copy link
Member

mit-mit commented Nov 25, 2020

Yes, I think that would be great. There are fair number of dependencies of this.

@kevmoo kevmoo merged commit 8268dd3 into google:master Nov 25, 2020
@kevmoo
Copy link
Collaborator

kevmoo commented Nov 25, 2020 via email

@Wikiwix
Copy link
Contributor Author

Wikiwix commented Nov 25, 2020

@kevmoo Just realised I missed to update the CHANGELOG.md accordingly.
Will you take care or should I make another PR?

@kevmoo
Copy link
Collaborator

kevmoo commented Nov 25, 2020

@kevmoo Just realised I missed to update the CHANGELOG.md accordingly.
Will you take care or should I make another PR?

Please do!

@Wikiwix Wikiwix mentioned this pull request Nov 25, 2020
Merged
@Wikiwix
Copy link
Contributor Author

Wikiwix commented Nov 25, 2020

@kevmoo Just realised I missed to update the CHANGELOG.md accordingly.
Will you take care or should I make another PR?

Please do!

See here: #25

@Wikiwix
Copy link
Contributor Author

Wikiwix commented Dec 16, 2020

@kevmoo Any word on when this will land as a prerelease?

@kevmoo
Copy link
Collaborator

kevmoo commented Dec 16, 2020

I can get this out today!

@kevmoo
Copy link
Collaborator

kevmoo commented Dec 16, 2020

Published!

@Wikiwix
Copy link
Contributor Author

Wikiwix commented Dec 16, 2020

Nice! Thanks :)

@Wikiwix Wikiwix deleted the null_safety branch March 9, 2021 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmoo kevmoo kevmoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wikiwix @mit-mit @kevmoo