Feature/cleanup

[Fox32]

I started this pull request with the goal to remove call chaining (#59) but I also took a look at "some" other things:

• Remove call chaining (breaking change, but the Dart Editor gives very good guidance here!)
• Rename some parts to match the Dart Style guide (constants, constructors, ...) (I only deprecated them)
• Removed some methods that didn't provide a real benefit (e.g. Sphere.copyOriginDirection)
• Formatting
• Analyser warnings
• Remove duplicate code (e.g. the plus operator of a vector can share the same code as VectorN.add)
• Add more documentation comments (especially for the collision detection objects)
• Improve code in a way that dart2js can generate better code. I took these suggestions as a start. Here is a example of dart2js code that changed, the old code:

dot$1: [function(other) {
      var t1, t2, t3, t4, t5, t6, t7;
      t1 = this.storage;
      t2 = t1[0];
      t3 = other.get$storage();
      t4 = t3.length;
      if (0 >= t4)
        return H.ioore(t3, 0);
      t5 = t3[0];
      t6 = t1[1];
      if (1 >= t4)
        return H.ioore(t3, 1);
      t7 = t3[1];
      t1 = t1[2];
      if (2 >= t4)
        return H.ioore(t3, 2);
      return t2 * t5 + t6 * t7 + t1 * t3[2];
    }, "call$1", "get$dot", 2, 0, null, 109, []],

and the new code:

    dot$1: [function(other) {
      var otherStorage, t1;
      otherStorage = other.get$_storage();
      t1 = this._storage;
      return t1[0] * otherStorage[0] + t1[1] * otherStorage[1] + t1[2] * otherStorage[2];
    }, "call$1", "get$dot", 2, 0, null, 109, []],

In this case range checks could be removed, in other cases less calls to getters are made. It also has a small influence on code size, but I don't think that these are significant. For the future it would be nice to have a test bench to compare the performance of changes in both the DartVM and Dart2Js. Not sure what to choose as a benchmark here, maybe some sort of simulation?

[johnmccutchan]

what's with this weird style?

[Fox32]

I used the new formatter that has some issues left. I can fix them by hand or leave them in until the formatter is fixed

[Fox32]

Thanke @dhenneke for helping me with additional Aabb3 and Obb3 intersecion tests!

[johnmccutchan]

Hi,

This is too big to review. Please break it into small pieces.

[Fox32]

I already plan that for some time, but haven't find the right way yet as some changes are very big on their own. But I will manage that somehow...

[johnmccutchan]

I recommend separating breaking changes from non-breaking changes and then further splitting up those change sets.

[Fox32]

My plan is to wait until the bigger cleanup PRs by others are finished. Currently merge conflicts are too annoying, especially the formatting.Then my plan is to do get vector_math back on a similar level as my fork. But I would prefer to make feature centered PRs, here is my plan:

• Fix vector normalizeLength (VectorX.normalizeLength isn't doing what it says in the description #88) #88 Fix VectorX.normalizeLength #91
• Fix VectorList stride Feature/fix vector list stride #92
• VectorList doc comments Vector list doc comments #93
• Standalone script for generating vector_math_64 Replace hop task to generate vector_math_64 with a standalone script #94
• Angles between vectors Add methods to calculate the unsigned and signed angle between two vectors #95
• Improve distanceTo performance Avoid creating new vector instances in distanceTo and distanceToSquared #96
• Copy rotation part fo Matrix4 Add a method for copying the rotation part of a Matrix4 #97
• Add asserts to setEnty Add asserts to entry and setEntry as a out of bound without an exception would be possible. #98
• Cleanup frustum Cleanup frustum #100
• SmoothStep & catmul rom Add smooth step and catmull rom interpolation funtions #101
• Top level library documentation Rename constants back to lowerCase #103
• Casing of constants (lower case, style guide was changed...) Rename constants back to lowerCase #103
• Matrix4.perspectiveTransform() Add perspective transform to Matrix4 #104
• Add quad Add quad class and cleanup triangle #105
• Cleanup triangle (add copyNormal) Add quad class and cleanup triangle #105
• Cleanup shere Cleanup sphere class #106
• Cleanup Quaternion Cleanup quaternion #107
• Cleanup ray Cleanup ray class #109
• Reorganise test files Cleanup tests #110
• Cleanup Aabb3 Cleanup aabb #112
• Cleanup Aabb2 Cleanup aabb #112
• Cleanup vector2 Cleanup Vector2 #114
• Cleanup vector3 Cleanup Vector3 #115
• Cleanup vector4 Cleanup vector4 #116
• Cleanup matrix2 Cleanup matrix2 #117
• Cleanup matrix3 Cleanup matrix3 #119
• Cleanup matrix4 Cleanup matrix4 #124
• Cleanup opengl Cleanup opengl #121
• Aabb <=> Triangle tests Add Aabb3 - Triangle intersection test #122
• Obb Add obb3 class #125
• set lenght as a setter Implement a length setter in vector2, vector3 and vector4 #123 (replaces Added setLength() method to Vector2, Vector3 and Vector4 #66)
• dart2js optimizations Use unique names for private storage fields in Vector(2,3,4), Matrix(2,3,4) #131
• Remove call chaining Remove call chaining. #133 (Call chaining support #59)

[kevmoo]

I like it, @Fox32.

Keep an eye on the new Box2d library as you move forward - https://github.com/google/box2d.dart

[kevmoo]

@Fox32 Do you have plans to track performance changes for these tweaks?

[Fox32]

@kevmoo I think I try to do the performance things later, but that Box2d would be a nice benchmark for some of the core classes, sadly Box2d isn't covering much of vector_math.
Beside that I would try to reduce the amount of type and bounds checks of the generade javascript code.

Do you have any bigger changes to vector_math in the pipeline?

[kevmoo]

@Fox32 Nope.

[kevmoo]

@Fox32 Keep things formatted using dartfmt with each of your commits so we can keep style-related churn to a minimum

[Fox32]

@kevmoo @johnmccutchan
I updated the list above with my current progress. I think we have enough PRs for now and I will wait till all are review, corrected, and merged. I starting to have dependencies between the PRs that makes further work to complicated for now.

[Fox32]

Everything, except call chaining, is now included \o/
I will close this one.

[johnmccutchan]

@Fox32 Thank you very much for your great work. Looking forward to 2.0 without call chaining.