Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/CD failing] Ruff version deprecated. #392

Closed
dabhicusp opened this issue Sep 12, 2023 · 2 comments
Closed

[CI/CD failing] Ruff version deprecated. #392

dabhicusp opened this issue Sep 12, 2023 · 2 comments

Comments

@dabhicusp
Copy link
Collaborator

In the code, we did not specify the Ruff version, so it pick the latest version (i.e. 0.0.288 for now) while running ci/cd pipeline. Unfortunately, this latest version deprecated this method type(value) which is used for checking variable types. This method is widely used in our codebase.

To resolve this issue, we have two options:

  1. Fix Ruff Version:
    We can fix the Ruff version in our code to a version(0.0.280) that still supports the type(value) method. This would maintain our existing code logic without changes.
  2. Replace type(value) with isinstance():
    We can modify our code to use the isinstance() method for checking variable types.

Please share your thoughts on which approach we should take. @alxmrs

@alxmrs
Copy link
Collaborator

alxmrs commented Sep 12, 2023

I recommend doing (1) for now, and then creating an issue to follow up to implement (2) to do later. (2) also fits our internal style standards.

dabhicusp added a commit that referenced this issue Sep 12, 2023
mahrsee1997 pushed a commit that referenced this issue Sep 13, 2023
* Polygon in bigquery injestion updated.

* Band-aid for Issue #392

* Data type of Geo_polygon is updated in schema.

* Test-cases updated.
@dabhicusp
Copy link
Collaborator Author

Closed this issue as this is fixed in #387.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants