-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI/CD failing] Ruff version deprecated. #392
Comments
I recommend doing (1) for now, and then creating an issue to follow up to implement (2) to do later. (2) also fits our internal style standards. |
mahrsee1997
pushed a commit
that referenced
this issue
Sep 13, 2023
* Polygon in bigquery injestion updated. * Band-aid for Issue #392 * Data type of Geo_polygon is updated in schema. * Test-cases updated.
Closed this issue as this is fixed in #387. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the code, we did not specify the Ruff version, so it pick the latest version (i.e. 0.0.288 for now) while running ci/cd pipeline. Unfortunately, this latest version deprecated this method
type(value)
which is used for checking variable types. This method is widely used in our codebase.To resolve this issue, we have two options:
We can fix the Ruff version in our code to a version(0.0.280) that still supports the
type(value)
method. This would maintain our existing code logic without changes.type(value)
withisinstance()
:We can modify our code to use the
isinstance()
method for checking variable types.Please share your thoughts on which approach we should take. @alxmrs
The text was updated successfully, but these errors were encountered: