Skip to content

Commit

Permalink
Make "revert now" more obvious (#137)
Browse files Browse the repository at this point in the history
* Add message for 'revert now' next to broom for visibility

* fix comment

* update

* add revert button text in static revision card

* update
  • Loading branch information
hrasyid authored and xinbenlv committed Dec 30, 2019
1 parent 0a17bd3 commit 38d3e34
Show file tree
Hide file tree
Showing 8 changed files with 11 additions and 4 deletions.
4 changes: 2 additions & 2 deletions components/RevisionCard.vue
Original file line number Diff line number Diff line change
Expand Up @@ -121,12 +121,12 @@
<button v-if="$store.state.flags.useDirectRevert && $store.state.user && $store.state.user.profile"
v-on:click="directRevert()"
class="btn btn-outline-primary">
<i class="fas fa-broom"></i>
<i class="fas fa-broom"></i> {{$t(`RevertNowBtnLabel`)}}
</button>
<button v-else
v-on:click="redirectToRevert()"
class="btn btn-outline-primary">
<i class="fas fa-broom"></i>
<i class="fas fa-broom"></i> {{$t(`RevertNowBtnLabel`)}}
</button>
</template>
</transition>
Expand Down
4 changes: 2 additions & 2 deletions components/StaticRevisionCard.vue
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,12 @@ between Client-Side-Rendering and Server-Side-Rendering -->
<button v-if="$store.state.flags.useDirectRevert && $store.state.user && $store.state.user.profile"
v-on:click="directRevert()"
class="btn btn-outline-primary">
<i class="fas fa-broom"></i>
<i class="fas fa-broom"></i> {{$t(`RevertNowBtnLabel`)}}
</button>
<button v-else
v-on:click="redirectToRevert()"
class="btn btn-outline-primary">
<i class="fas fa-broom"></i>
<i class="fas fa-broom"></i> {{$t(`RevertNowBtnLabel`)}}
</button>
</template>
</transition>
Expand Down
1 change: 1 addition & 0 deletions locales/de.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ module.exports = {
LooksGoodBtnLabel: "Sieht gut aus",
NotSureBtnLabel: "Nicht sicher",
ShouldRevertBtnLabel: "Sollte zurücksetzen",
// RevertNowBtnLabel: "Revert now", # TODO: translate
NextBtnLabel: "Nächste",
Loading: "Beladung",
EditedTimeLabel: "Bearbeitet"
Expand Down
1 change: 1 addition & 0 deletions locales/en.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ module.exports = {
LooksGoodBtnLabel: "Looks good",
NotSureBtnLabel: "Not sure",
ShouldRevertBtnLabel: "Should revert",
RevertNowBtnLabel: "Revert now",
NextBtnLabel: "Next",
Loading: "Loading",
EditedTimeLabel: "edited",
Expand Down
1 change: 1 addition & 0 deletions locales/fr.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ module.exports = {
LooksGoodBtnLabel: "Cela semble bon",
NotSureBtnLabel: "Pas sûr",
ShouldRevertBtnLabel: "Devrait revenir",
// RevertNowBtnLabel: "Revert now", # TODO: translate
NextBtnLabel: "Suivant",
Loading: "Chargement",
EditedTimeLabel: "édité"
Expand Down
2 changes: 2 additions & 0 deletions locales/id.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,15 @@ module.exports = {
LoginMenuItem: "Masuk log",
LogoutMenuItem: "Keluar log",
ContributionsMenuItem: "Kontribusi",
ContributionsBeforeLoginMenuItem: "Daftar kontribusi sebelum masuk log",
Anonymous: "Anonim",
Me: "Aku",
Someone: "Seseorang",
EditSummaryLabel: "Ringkasan suntingan",
LooksGoodBtnLabel: "Kelihatan bagus",
NotSureBtnLabel: "Tidak yakin",
ShouldRevertBtnLabel: "Patut dibatalkan",
RevertNowBtnLabel: "Batalkan sekarang",
NextBtnLabel: "Selanjutnya",
Loading: "Sedang memuat",
EditedTimeLabel: "disunting",
Expand Down
1 change: 1 addition & 0 deletions locales/tr.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ module.exports = {
LooksGoodBtnLabel: "İyi Görünüyor",
NotSureBtnLabel: "Emin Değilim",
ShouldRevertBtnLabel: "Eski Haline Dönmeli",
// RevertNowBtnLabel: "Revert now", # TODO: translate
NextBtnLabel: "Sonraki",
Loading: "Yükleniyor",
EditedTimeLabel: "düzenlendi",
Expand Down
1 change: 1 addition & 0 deletions locales/zh.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ module.exports = {
LooksGoodBtnLabel: "看着不错",
NotSureBtnLabel: "不确定",
ShouldRevertBtnLabel: "应该撤回",
// RevertNowBtnLabel: "Revert now", # TODO: translate
Loading: "读取中",
EditedTimeLabel: "编辑于",
DiffNotAvailable: "该页面的版本差异暂时无法读取,可以嘗試重新載入。有时被破壞的版本可能被完全删除,您可以查看页面历史。"
Expand Down

0 comments on commit 38d3e34

Please sign in to comment.