Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "revert now" more obvious #137

Merged
merged 7 commits into from
Dec 30, 2019
Merged

Make "revert now" more obvious #137

merged 7 commits into from
Dec 30, 2019

Conversation

hrasyid
Copy link
Collaborator

@hrasyid hrasyid commented Dec 27, 2019

Otherwise it's not obvious to people that they can revert.
Note: Only translated two languages, in other languages it will show up in English.

@xinbenlv xinbenlv temporarily deployed to wikiloop-bat-broom-2nx9jr4bqxy December 30, 2019 18:58 Inactive
@xinbenlv
Copy link
Contributor

xinbenlv commented Dec 30, 2019

Ideally, a user click on the button "ShouldRevert", and it will let people mark it as "ShouldRevert" and then there is an additional button showing up, and asks "do you want to revert them directly?", if user continue to click on it, it will revert the revision. (and user shall be able to also decide that they can "always conduct revert when marking ShouldRevert" ).

Also, the revision needs to be eligible to revert - meaning:

I would love to let this PR go through, even though I think it will only be a temp optimization. We need follow up commits for aforementioned functions.

There is one blocking request for you before I merge this PR in:

  • can you make sure when people revert directly, their label also gets marked as "ShouldRevert"?

@xinbenlv xinbenlv changed the title Add button text for 'revert now' next to broom for visibility Make "revert now" more obvious Dec 30, 2019
@xinbenlv
Copy link
Contributor

Nevermind, I found out that you are only adding a label, instead of showing the "should revert" all th time. This PR is good to go in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants