Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run Clippy on nightly? #328

Closed
joshlf opened this issue Sep 5, 2023 · 0 comments · Fixed by #332
Closed

Only run Clippy on nightly? #328

joshlf opened this issue Sep 5, 2023 · 0 comments · Fixed by #332
Labels
compatibility-nonbreaking Changes that are (likely to be) non-breaking

Comments

@joshlf
Copy link
Member

joshlf commented Sep 5, 2023

We have a lot of boilerplate code which is meant to work around old Clippy warnings that have been more recently removed. If we were to only run Clippy on nightly in CI, we could clean up a lot of this code. Are there any downsides to not running Clippy on MSRV or stable?
@joshlf joshlf added the compatibility-nonbreaking Changes that are (likely to be) non-breaking label Sep 5, 2023
joshlf added a commit that referenced this issue Sep 5, 2023
@joshlf
[CI] Only run Clippy on nightly
7287ec6 
Closes #328
@joshlf joshlf mentioned this issue Sep 5, 2023
Merged
joshlf added a commit that referenced this issue Sep 5, 2023
@joshlf
[CI] Only run Clippy on nightly
2156651 
Update pinned nightly in CI to be able to take
advantage of more recent Clippy version.

Closes #328
joshlf added a commit that referenced this issue Sep 5, 2023
@joshlf
[CI] Only run Clippy on nightly
971688a 
Update pinned nightly in CI to be able to take
advantage of more recent Clippy version.

Closes #328
joshlf added a commit that referenced this issue Sep 5, 2023
@joshlf
[CI] Only run Clippy on nightly
dd76688 
Closes #328
joshlf added a commit that referenced this issue Sep 5, 2023
@joshlf
[CI] Only run Clippy on nightly (#332)
93ccf62 
Closes #328
@joshlf joshlf mentioned this issue Sep 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility-nonbreaking Changes that are (likely to be) non-breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CI] Only run Clippy on nightly google/zerocopy
1 participant
@joshlf