Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Use --all-targets with cargo check #96

Closed
wants to merge 4 commits into from

Conversation

jswrenn
Copy link
Collaborator

@jswrenn jswrenn commented Oct 22, 2022

Ensures that examples, benchmarks, etc. are also checked.

Fixes #95.

Copy link
Member

@joshlf joshlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One uber nit, but otherwise looks good.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Ensures that examples, benchmarks, etc. are also checked.

Fixes google#95.
@joshlf
Copy link
Member

joshlf commented Oct 25, 2022

Looks like the current errors are probably caused by not passing the right linker as described in rust-lang/rust#28924. It may be worth just punting on this for cargo build and only doing it for cargo check unless there's an easy way to provide the linker flag that doesn't significantly increase the complexity of our CI tests or their configs.

@joshlf
Copy link
Member

joshlf commented Oct 24, 2023

This is captured by our build matrix.

@joshlf joshlf closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Use cargo check/build --all-targets flag
2 participants