Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: support "minutes" for duration #703

Closed
perrinjerome opened this issue Nov 30, 2023 · 0 comments · Fixed by #704
Closed

Feature request: support "minutes" for duration #703

perrinjerome opened this issue Nov 30, 2023 · 0 comments · Fixed by #704

Comments

@perrinjerome
Copy link

How about supporting something like this ?

Expected Behavior

import 'zx/globals'
await $`sleep 2m`.timeout("1m")

Actual Behavior

Error: Unknown duration: "1m".
@RezaKargar RezaKargar mentioned this issue Dec 2, 2023
Merged
antonmedv added a commit that referenced this issue Mar 28, 2024
@RezaKargar @antonmedv
Add minute support in duration (#703) (#704)
b02fd52 
* Add minute support for parseDuration

* Add minute to Duration type

* Fix formatting issue of Duration type in util.ts

* Add test for minute in duration parsing

---------

Co-authored-by: Anton Medvedev <anton@medv.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add minute support in duration (#703) RezaKargar/zx
1 participant
@perrinjerome