Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop webpod ssh API #750

Merged
merged 1 commit into from Mar 28, 2024
Merged

refactor: drop webpod ssh API #750

merged 1 commit into from Mar 28, 2024

Conversation

antongolub
Copy link
Contributor

@antongolub antongolub commented Mar 27, 2024

// import {ssh} from 'zx'
import {ssh} from 'webpod'

@antongolub antongolub marked this pull request as draft March 27, 2024 15:50
@antongolub antongolub marked this pull request as ready for review March 27, 2024 15:51
@antongolub antongolub mentioned this pull request Mar 27, 2024
@antonmedv antonmedv merged commit 8925a12 into google:main Mar 28, 2024
10 checks passed
@antongolub antongolub deleted the drop-ssh branch March 28, 2024 06:40
@nightwolfz
Copy link

nightwolfz commented Apr 7, 2024

There goes the only feature that made zx worth using for me

@antongolub
Copy link
Contributor Author

antongolub commented Apr 7, 2024

I'm afraid, the current ssh() helper impl adds too much code duplication to the zx bundle, so we're planning to refactor this API in future. But you're still able to add webpod separately to bring this functionality back.

@antonmedv
Copy link
Collaborator

Well. Now just use webpod.dev ;)

@transtone
Copy link

Well. Now just use webpod.dev ;)
@antonmedv
webpod/webpod#6

@nightwolfz
Copy link

nightwolfz commented Apr 9, 2024

Well. Now just use webpod.dev ;)

Yup , webpod is awesome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants