fix: allow spaces in commands #778
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonmedv
reviewed
Apr 13, 2024
| @@ -48,7 +48,7 @@ export function noquote(): string { | |||
| } | |||
|
|
|||
| export function quote(arg: string) { | |||
| if (/^[a-z0-9/_.\-@:=]+$/i.test(arg) || arg === '') { | |||
| if (/^[a-z0-9/_.\-@:= ]+$/i.test(arg) || arg === '') { | |||
There was a problem hiding this comment.
This is wrong. quote should NOT allow space char.
|
Please read doc at https://google.github.io/zx/quotes |
antonmedv
reviewed
Apr 13, 2024
| @@ -57,6 +57,7 @@ describe('util', () => { | |||
|
|
|||
| test('quote()', () => { | |||
| assert.ok(quote('string') === 'string') | |||
| assert.ok(quote('this that') === 'this that') | |||
There was a problem hiding this comment.
The quote('this that') MUST quote output with $.
There was a problem hiding this comment.
@antonmedv I think I have come at a side effect of the real issue then. I will re-attempt one more time.
markrzen
commented
Apr 13, 2024
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| await $`cat package.json | grep name` | |||
|
|
|||
| let branch = await $`git branch --show-current` | |||
| let { stdout: branch } = await $`git branch --show-current` | |||
There was a problem hiding this comment.
Noticed this discrepancy in the documentation.
There was a problem hiding this comment.
Nope. This is not a discrepancy. zx works this way.
| @@ -57,6 +57,7 @@ describe('util', () => { | |||
|
|
|||
| test('quote()', () => { | |||
| assert.ok(quote('string') === 'string') | |||
| assert.ok(quote('this that') === 'this that') | |||
There was a problem hiding this comment.
@antonmedv I think I have come at a side effect of the real issue then. I will re-attempt one more time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #700
Allows for spaces to exist in commands.