Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: list types first in package exports #812

Merged
merged 2 commits into from
May 17, 2024

Conversation

timostroehlein
Copy link
Contributor

According to Node.js documentation the types should always be listed first when using package exports, see:
https://nodejs.org/api/packages.html#community-conditions-definitions

This also fixes an issue with eslint-plugin-import throwing a warning Parse errors in imported module 'zx': parserPath or languageOptions.parser is required! (undefined:undefined) due to the wrong order of package exports.

Copy link

google-cla bot commented May 16, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@antongolub
Copy link
Contributor

I believe this is true, but I don't want it to be so. Ordered unordered collection is pure madness.

An object is a member of the type Object. It is an unordered collection of properties each of which contains a
primitive value, object, or function. A function stored in a property of an object is called a method.

@antonmedv antonmedv merged commit 23fe548 into google:main May 17, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants