Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Logging Error Parsing #34

Closed
BenRKarl opened this issue Feb 5, 2019 · 1 comment
Closed

Cleanup Logging Error Parsing #34

BenRKarl opened this issue Feb 5, 2019 · 1 comment
Assignees
@BenRKarl
Labels
enhancement New feature or request P3 Prospects for future development or feature requests that would be nice to have. Typos or minor bugs

Comments

@BenRKarl
Copy link
Contributor

BenRKarl commented Feb 5, 2019

With the release of API v0_7 we merged this PR in order to eliminate the bugs related to logging (i.e. parsing data from error objects), as described in issues such as this.

I'd like to revisit this implementation and refactor it using Eric's feedback in the PR.
@BenRKarl BenRKarl added the enhancement New feature or request label Feb 5, 2019
@BenRKarl BenRKarl self-assigned this Feb 5, 2019
@BenRKarl BenRKarl added the P3 Prospects for future development or feature requests that would be nice to have. Typos or minor bugs label May 10, 2019
@BenRKarl BenRKarl removed their assignment Mar 22, 2022
@BenRKarl BenRKarl self-assigned this Apr 5, 2022
@BenRKarl
Copy link
Contributor Author

BenRKarl commented Apr 5, 2022

Closing this out, as we haven't had issues with these changes in over three years, and the discussion in the PR now appears quite outdated.

@BenRKarl BenRKarl closed this as completed Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenRKarl BenRKarl

Labels
enhancement New feature or request P3 Prospects for future development or feature requests that would be nice to have. Typos or minor bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BenRKarl