Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Oath (Verizon Ads SDK) Adapter v1.0.3.0 #103

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@mmullin
Copy link

commented Feb 27, 2019

This pull request replaces #102. Please note that the adapter must be used with Verizon Ads SDK v1.0.3.

@googlebot googlebot added the cla: yes label Feb 27, 2019

GADAdSizeEqualToSize(kGADAdSizeSmartBannerLandscape, adSize) ) {
int offsetX = (int)(windowSize.width / 2);

if ( windowSize.height < MM_SMARTBANNER_MED_CUTOFF ) {

This comment has been minimized.

Copy link
@joshuajplagonera

joshuajplagonera May 3, 2019

Collaborator

Should these be checking for width instead of height?

When making a SmartBanner request for a phone, it's trying to return a size applicable for a tablet (MM_SMARTBANNER_TABLET) instead of for a phone, causing the returning banner to be too large for the ad view.


if ( windowSize.height < MM_SMARTBANNER_MED_CUTOFF ) {
// MYDAS will attempt to return a 320x50, even when hsht < 320 / hswd < 50
return CGRectMake(0,0,-1,-1);

This comment has been minimized.

Copy link
@joshuajplagonera

joshuajplagonera May 3, 2019

Collaborator

Should this return MM_SMARTBANNER_PHONE size rather than -1, since the ad request will fail if this method returns a width less than 0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.