-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding audits for deprecated api and general error catching #252
Conversation
Implementation LGTM aside from comments. We will probably discuss scoring when you add For testing, can we create some smoke tests? |
const consoleRows = artifacts.ConsoleMessages | ||
.filter((item) => item.level === 'warning' || item.level === 'error') | ||
.filter((item) => item.url && isGpt(item.url)) | ||
.filter((item) => item.text.toLowerCase().includes('deprecated')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or discouraged
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the condition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify, added both cases in since we use both words in console messages.
Ooops! Sorry! I had my comments stuck as draft. Posted them now |
No description provided.