Adding audits for deprecated api and general error catching #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Implementation LGTM aside from comments. We will probably discuss scoring when you add For testing, can we create some smoke tests? |
warrengm
requested changes
Jan 11, 2021
| const consoleRows = artifacts.ConsoleMessages | ||
| .filter((item) => item.level === 'warning' || item.level === 'error') | ||
| .filter((item) => item.url && isGpt(item.url)) | ||
| .filter((item) => item.text.toLowerCase().includes('deprecated')) |
There was a problem hiding this comment.
Added the condition.
There was a problem hiding this comment.
To clarify, added both cases in since we use both words in console messages.
|
Ooops! Sorry! I had my comments stuck as draft. Posted them now |
warrengm
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.