feat: adds ad log, fixes #698 #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnbuso
suggested changes
Jul 24, 2018
src/player-wrapper.js
Outdated
| */ | ||
| PlayerWrapper.prototype.onAdLog = function(adEvent) { | ||
| const adData = adEvent.getAdData(); | ||
| if (adData['adError']) { |
There was a problem hiding this comment.
We call this adlog, but we only propagate it if it's an error inside of a log. We should either rename it (nonFatalError or something) or just propagate all LOG messages and let the user check to see if it's an error or not.
There was a problem hiding this comment.
I made it pass along the entire LOG message, in addition to the error message, if present.
shawnbuso
approved these changes
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.